feat(v9): Remove deprecated setExtraValue #5864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
requested review from
itaybre,
philipphofmann and
philprime
as code owners
|
noahsmartin
force-pushed
the
removeDeprecatedSpanV9
branch
from
c1b414c to
23eeee5
Compare
noahsmartin
commented
Aug 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5864 +/- ##
=============================================
+ Coverage 86.528% 86.664% +0.135%
=============================================
Files 423 423
Lines 36574 36587 +13
Branches 15697 17330 +1633
=============================================
+ Hits 31647 31708 +61
+ Misses 4885 4835 -50
- Partials 42 44 +2
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 650d802 | 1231.86 ms | 1255.64 ms | 23.78 ms |
| 2a9a505 | 1221.49 ms | 1238.49 ms | 17.00 ms |
| be6a4ee | 1226.33 ms | 1249.77 ms | 23.44 ms |
| 736bcfb | 1229.86 ms | 1249.59 ms | 19.73 ms |
| 45482a6 | 1225.88 ms | 1254.27 ms | 28.39 ms |
| ccf1278 | 1226.84 ms | 1248.51 ms | 21.67 ms |
| 51b7dd3 | 1235.06 ms | 1258.21 ms | 23.15 ms |
| f37e3fe | 1230.24 ms | 1254.51 ms | 24.27 ms |
| 701b301 | 1226.10 ms | 1245.57 ms | 19.47 ms |
| 94a6b1a | 1213.39 ms | 1231.55 ms | 18.17 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 650d802 | 23.74 KiB | 913.13 KiB | 889.39 KiB |
| 2a9a505 | 23.75 KiB | 874.46 KiB | 850.71 KiB |
| be6a4ee | 23.75 KiB | 913.14 KiB | 889.39 KiB |
| 736bcfb | 23.74 KiB | 891.02 KiB | 867.28 KiB |
| 45482a6 | 23.75 KiB | 919.91 KiB | 896.16 KiB |
| ccf1278 | 23.75 KiB | 877.15 KiB | 853.40 KiB |
| 51b7dd3 | 23.75 KiB | 913.26 KiB | 889.52 KiB |
| f37e3fe | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| 701b301 | 23.75 KiB | 867.16 KiB | 843.41 KiB |
| 94a6b1a | 23.75 KiB | 902.48 KiB | 878.74 KiB |
Previous results on branch: removeDeprecatedSpanV9
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1322334 | 1233.04 ms | 1249.02 ms | 15.98 ms |
| 8708980 | 1214.41 ms | 1245.45 ms | 31.04 ms |
| 5b555af | 1223.71 ms | 1252.31 ms | 28.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1322334 | 23.75 KiB | 920.74 KiB | 896.99 KiB |
| 8708980 | 23.75 KiB | 919.91 KiB | 896.16 KiB |
| 5b555af | 23.75 KiB | 913.64 KiB | 889.89 KiB |
noahsmartin
force-pushed
the
removeDeprecatedSpanV9
branch
2 times, most recently
from
039a635 to
73d5bda
Compare
noahsmartin
force-pushed
the
removeDeprecatedSpanV9
branch
from
73d5bda to
6d71f9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a deprecated function from V9
#skip-changelog